Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-byte language length support #1061

Closed
lbz-sugimoto opened this issue Nov 15, 2021 · 2 comments
Closed

multi-byte language length support #1061

lbz-sugimoto opened this issue Nov 15, 2021 · 2 comments

Comments

@lbz-sugimoto
Copy link

lbz-sugimoto commented Nov 15, 2021

Description

Current code treats one multi byte character (some Eastern Asian languages) as 3 words. It restricts word count more than expected, especially in header/footer section.

https://github.com/qax-os/excelize/blob/master/sheet.go#L1094-L1098

for i := 4; i < v.NumField()-1; i++ {
    if v.Field(i).Len() >= 255 {
        return fmt.Errorf("field %s must be less than 255 characters", v.Type().Field(i).Name)
    }
}
@xuri xuri closed this as completed in bda8e7f Nov 15, 2021
@xuri
Copy link
Member

xuri commented Nov 15, 2021

Thanks for your issue, I have fixed it, please upgrade to the master branch code, and this patch will be released in the next version.

@lbz-sugimoto
Copy link
Author

Appreciate your quick fix. Thanks!

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
…oter

typo fixed and simplify code for read the data values arguments of formula functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants