-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HRV area definition tests #903
Conversation
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
=========================================
Coverage ? 84.84%
=========================================
Files ? 171
Lines ? 25297
Branches ? 0
=========================================
Hits ? 21464
Misses ? 3833
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should h
be converted to float here as well? https://github.com/pytroll/satpy/blob/master/satpy/readers/utils.py#L138
And one nitpick: Maybe it would be more clear to explicitly convert the proj dict items to float instead of dividing them by 1000.
.
Some tests were failing with the newer pyproj.
The main problem was that pyproj is now converting floats to ints when possible for the projection parameters, hence triggering some errors.
flake8 satpy