Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Invalid Metadata From ACSPO Reader #843

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Conversation

wroberts4
Copy link
Contributor

_FillValue is not used since all invalid data is mapped to nan. _FillValue, valid_max , and valid_min
cause misinformation to other software because of the former statement.

  • Closes #xxxx
  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@wroberts4 wroberts4 requested a review from djhoese as a code owner July 3, 2019 15:10
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #843 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
- Coverage   84.09%   84.09%   -0.01%     
==========================================
  Files         167      167              
  Lines       24546    24549       +3     
==========================================
+ Hits        20642    20644       +2     
- Misses       3904     3905       +1
Impacted Files Coverage Δ
satpy/readers/acspo.py 86.25% <100%> (+0.53%) ⬆️
satpy/scene.py 90.47% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7360647...f5be913. Read the comment docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhoese djhoese merged commit da0cf50 into pytroll:master Jul 3, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.093% when pulling f5be913 on wroberts4:master into 7360647 on pytroll:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants