-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NWCSAF GEO v2018, retain support for v2016 #820
Conversation
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 83.63% 83.61% -0.02%
==========================================
Files 167 167
Lines 24490 24503 +13
==========================================
+ Hits 20481 20488 +7
- Misses 4009 4015 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all these products, it looks good to me.
@simonrp84 As a user, I would be interested in having access to documentation about these product. Do you know of a link to these that we could append to the documentation ? |
Most of the documentation is here: http://www.nwcsaf.org/web/guest/archive |
Ok, thanks. Can you maybe add it to the nwcsaf module documentation ? I can't think of a better place to put it. |
Ok, I fixed the link to the documentation so that the PR ready to merge |
This PR allows SatPy to read files created by the NWC-SAF's recently released GEO software, version 2018. The main changes are that the ASII-NG module has been split into -TF and -GF components.
The iSHAI module also has quite a few new variables (mainly differences between retrieved and NWP values).
I have also added the status_flag, conditions and quality flags for the majority of data, in case these are useful to the user. This is a repeat of PR #631, but with some changes to allow support for both 2016 and 2018 files. It also doesn't include an erroneous commit on the VIIRS files...
flake8 satpy