-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VIIRS EDR Active Fires #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions and a couple changes.
Also, could you add some information in the top docstring of the reader python module about the different file types (AFEDR is the pre-release (dev) version of the product); like MOD versus IMG differences (confidence, etc)?
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
+ Coverage 80.67% 80.78% +0.11%
==========================================
Files 149 149
Lines 21661 21773 +112
==========================================
+ Hits 17474 17590 +116
+ Misses 4187 4183 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like some cleanup on the platform handling. Otherwise looking good.
I was going to ask why the CLASS active fires files weren't included but then remembered that the files I gave you didn't have any fires in them. I went to CLASS to try to find some and can't even find the product to be able to download new files...so I guess we'll support them when they are more widely used/available. |
Updates the VIIRS EDR Active Fires reader to read
AFEDR
,AFIMG
, andAFMOD
NetCDF and CSV files.For
AFEDR
andAFMOD
, the following parameters can be accessed:For
AFIMG
, the following parameters can be accessed:confidence_cat
power
T4
latitude & longitude
Closes Update 'viirs_edr_active_fires' reader to read newest algorithm output #725
Tests added
Tests passed
Passes
git diff origin/master -- "*py" | flake8 --diff