-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes in the Electro-L reader #726
Conversation
…ly there was a bug that caused an error due to a map_blocks call not passing the correct variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and I see why the map_blocks was failing. My fault, so thanks for fixing it.
I think in the long term we should consider renaming the reader since electrol
is technically the satellite and not the sensor (even though OSCAR lists the sensor as "Electrol Imager").
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 80.02% 80.44% +0.42%
==========================================
Files 147 148 +1
Lines 21498 21612 +114
==========================================
+ Hits 17203 17385 +182
+ Misses 4295 4227 -68
Continue to review full report at Codecov.
|
Lgtm, feel free to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ernst made a bug report in the google group: https://groups.google.com/forum/#!topic/pytroll/Dvvp9z2bIdc
Stating that he could not process or save images from the Electro-L satellite. This was for two reasons:
satpy/etc/readers/electrol_hrit.yaml
the sensor was incorrectly namedelectrol
rather thanmsu-gs
.TypeError: _getitem() missing 1 required positional argument: 'lut'
was being raised.This PR fixes both of these problems by adding the correct sensor name and by passing
lut
to the `_getitem" call.git diff origin/master -- "*py" | flake8 --diff