Use HSD blocklengths rather than assumed size #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he file header, rather than relying on fixed length headers.
|
I also added myself to the Authors list (both in the python file and in AUTHORS.md). Happy to remove that if it's not appropriate. |
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=========================================
+ Coverage 79.05% 79.56% +0.5%
=========================================
Files 140 145 +5
Lines 20802 21176 +374
=========================================
+ Hits 16446 16849 +403
+ Misses 4356 4327 -29
Continue to review full report at Codecov.
|
|
Nice! As extra security, it would be nice if we could issue a warning when the blocklength doesn't match the size of the dtype we are using to read. Could you add that ? |
djhoese
reviewed
Apr 4, 2019
…se a warning if it does not.
stickler-ci
reviewed
Apr 8, 2019
stickler-ci
reviewed
Apr 8, 2019
…(mock_open was unused).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the AHI HSD reader navigated through a data file by using assumed-length headers. However, these headers contain descriptors that give the actual length of the header. This PR uses these descriptors to ensure that we always navigate to the correct position in the file (using file.seek) rather than just assuming that each header is always of a certain size.
git diff origin/master -- "*py" | flake8 --diff