Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTTH composite not to mark invalid data as cloud-free #661

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 15, 2019

This PR fixes a bug that appears when the cloud height product is generated after resampling.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@mraspaud mraspaud self-assigned this Mar 15, 2019
@mraspaud mraspaud added this to the v0.13 milestone Mar 15, 2019
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #661 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   78.55%   78.53%   -0.02%     
==========================================
  Files         138      138              
  Lines       20089    20089              
==========================================
- Hits        15781    15777       -4     
- Misses       4308     4312       +4
Impacted Files Coverage Δ
satpy/tests/compositor_tests/__init__.py 99.32% <100%> (ø) ⬆️
satpy/composites/cloud_products.py 87.87% <100%> (ø) ⬆️
satpy/readers/__init__.py 93.33% <0%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cdacb...5348689. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 78.531% when pulling 5348689 on mraspaud:fix-cloud-products into 70cdacb on pytroll:master.

@mraspaud mraspaud merged commit 0984694 into pytroll:master Mar 15, 2019
@mraspaud mraspaud deleted the fix-cloud-products branch March 15, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants