Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resampling of ancillary variables when also first class datasets #652

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 13, 2019

Sometimes, datasets from a scene are also an ancillary variable to another dataset. When resampling such a scene, only one of the instances of that dataset was actually replaced by the resampled version. This PR fixes this.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@mraspaud mraspaud added this to the v0.13 milestone Mar 13, 2019
@mraspaud mraspaud self-assigned this Mar 13, 2019
@mraspaud mraspaud requested a review from djhoese March 13, 2019 16:06
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #652 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   78.39%   78.44%   +0.04%     
==========================================
  Files         138      138              
  Lines       19980    20002      +22     
==========================================
+ Hits        15664    15690      +26     
+ Misses       4316     4312       -4
Impacted Files Coverage Δ
satpy/scene.py 88.95% <100%> (+0.81%) ⬆️
satpy/tests/test_scene.py 99.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5ba34...27df564. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 78.442% when pulling 27df564 on mraspaud:fix-resample-ancillary into bc5ba34 on pytroll:master.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this as much or as little as I think I do, looks good to me. All this complication with ancillary variables makes me think we need to handle xarray.Dataset objects and that that may help simplify this...somehow.

@djhoese djhoese merged commit acfdafa into pytroll:master Mar 14, 2019
@mraspaud mraspaud deleted the fix-resample-ancillary branch March 14, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants