-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader for the SAR OCN L2 wind product in SAFE format. #645
Conversation
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
=========================================
+ Coverage 79.31% 79.4% +0.08%
=========================================
Files 145 147 +2
Lines 21120 21224 +104
=========================================
+ Hits 16752 16852 +100
- Misses 4368 4372 +4
Continue to review full report at Codecov.
|
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
"""Module for testing the satpy.readers.safe_rsae_l2_ocn module. | ||
""" | ||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'os' imported but unused
""" | ||
import os | ||
import sys | ||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'numpy as np' imported but unused
import os | ||
import sys | ||
import numpy as np | ||
import xarray as xr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'xarray as xr' imported but unused
from satpy.readers.safe_sar_l2_ocn import SAFENC | ||
from satpy import DatasetID | ||
|
||
ds_id = DatasetID(name='foo') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F841 local variable 'ds_id' is assigned to but never used
'fstart_time': 0, 'fend_time': 0, | ||
'polarization': 'vv'} | ||
|
||
test = SAFENC('S1A_IW_OCN__2SDV_20190228T075834_20190228T075849_026127_02EA43_8846.SAFE/measurement/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F841 local variable 'test' is assigned to but never used
import sys | ||
import numpy as np | ||
import xarray as xr | ||
from satpy.tests.reader_tests.test_netcdf_utils import FakeNetCDF4FileHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'satpy.tests.reader_tests.test_netcdf_utils.FakeNetCDF4FileHandler' imported but unused
except ImportError: | ||
import mock | ||
|
||
class TestSAFENC(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1
filetype_info={}) | ||
|
||
|
||
def test_init(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E303 too many blank lines (2)
|
||
def test_get_dataset(self): | ||
for ch in self.channels: | ||
dt = self.reader.get_dataset( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F841 local variable 'dt' is assigned to but never used
How should I ask for a review @mraspaud? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To ask for review, you can ping us like you did :) |
Adding reading for the SAR OCN L2 wind product in SAFE format
git diff origin/master -- "*py" | flake8 --diff