Fix sunz_corrected modifier adding unnecessary x and y coordinates #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #587 for details. This is a replacement for that PR.
In summary, the sunz_corrected modifier was adding new x and y coordinates to the SZA data it was creating. This happened because
my_data_arr['y']
will create a new data array even if the'y'
coordinate doesn't exist. The value would be a range representing the indexes of the array. The way this was being used was adding y/x coordinates to the dataset when the original array didn't have them. This would then add these coordinates to the input data and pass it on to the DayNightCompositor. The DayNightCompositor would then get confused if it had y/x for one dataset and no coordinates for the other. This PR makes it so those coordinates are only added if they already existed in the input data to the sunz_corrected modifier.git diff origin/master -- "*py" | flake8 --diff