Fix available_composite_ids including inline comp dependencies #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes inline composite dependencies being listed in
available_composite_ids/names
and theall_composite_ids/names
. The point of inline compositors is to not have to put as much work in to "officially" defining new composites and they shouldn't be needed by 99% of users. It can be confusing to see these dependencies (ex.airmass_dep_0
) in the list coming fromScene.available_composite_ids
.This PR prefixes these inline dependencies with a
_
and then ignores composites with that name when listing them in the Scene's methods.git diff origin/master -- "*py" | flake8 --diff