Improve the SAR-C reading and Ice composite #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Dec 20, 2018
mraspaud
added
enhancement
|
New version of the composite
Compared to the old version
|
|
Other example, Greenland:
|
|
|
stickler-ci
reviewed
Dec 20, 2018
|
The sar-land product:
|
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 78.29% 78.03% -0.26%
==========================================
Files 136 137 +1
Lines 19725 19850 +125
==========================================
+ Hits 15443 15490 +47
- Misses 4282 4360 +78
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Jan 14, 2019
djhoese
reviewed
Mar 5, 2019
satpy/composites/sar.py
Outdated
| """Blending two layers. | ||
|
|
||
| from: https://docs.gimp.org/en/gimp-concepts-layer-modes.html | ||
| """ | ||
| maxval = xu.maximum(top.max(), bottom.max()) | ||
| if maxval is None: | ||
| maxval = xu.maximum(top.max(), bottom.max()) |
There was a problem hiding this comment.
Looks like multiple cases in this module at least.
djhoese
approved these changes
Mar 5, 2019
mraspaud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the sar-ice composite more stable and switches reading rasterio.
Using rasterio facilitates the access to the GCPs and these are added to the lons and lats to allow saving them later on.
git diff origin/master -- "*py" | flake8 --diff