Fix 'get_filename' call in 'ninjo' writer #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
reviewed
Nov 26, 2018
satpy/writers/ninjotiff.py
Outdated
| @@ -49,5 +49,5 @@ def save_image(self, img, filename=None, **kwargs): # floating_point=False, | |||
|
|
|||
| .. _ninjotiff: http://www.ssec.wisc.edu/~davidh/polar2grid/misc/NinJo_Satellite_Import_Formats.html | |||
| """ | |||
| filename = filename or self.get_filename(**img.info) | |||
| filename = filename or self.get_filename() | |||
There was a problem hiding this comment.
Sorry:
filename = filename or self.get_filename(**img.data.attrs)
There was a problem hiding this comment.
Yes, you are right, I have just tested it. I update this PR right away, thanks for checking.
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 74.62% 74.62%
=======================================
Files 136 136
Lines 18342 18342
=======================================
Hits 13687 13687
Misses 4655 4655
Continue to review full report at Codecov.
|
djhoese
approved these changes
Nov 27, 2018
|
Can we merge this @loreclem ? |
djhoese
changed the title
|
I would say so, David approved it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff origin/master -- "*py" | flake8 --diff