Deprecate 'enhancement_config' keyword argument in favor of 'enhance' #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ways of specifying custom enhancement are inconsistent between
save_dataset
-type methods andget_enhanced_image
and theEnhancer
class that actually applies the enhancement. There isenhancement_config
andenhancement_config_file
, but most of the time the user just wants to say "don't enhance anything". To me the clearest way that a user could ask for this would be:which is now how it works. A user can also provide a
Enhancer
instance if they really want to. This PR also sets things up for the future where I would like to reinvent the enhancement interface to make it a separate step for the user.git diff origin/master -- "*py" | flake8 --diff