Refactor SCMI writer to be dask friendly #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes support for RGB datasets
djhoese
added
enhancement
stickler-ci
reviewed
Oct 31, 2018
| 'test', | ||
| 'test', | ||
| 'test', | ||
| proj_dict=proj4_str_to_dict('+proj=lcc +datum=WGS84 +ellps=WGS84 +lon_0=-95. +lat_0=25 +lat_1=25 +units=m +no_defs'), |
There was a problem hiding this comment.
E501 line too long (129 > 120 characters)
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=========================================
+ Coverage 74.15% 74.25% +0.1%
=========================================
Files 136 136
Lines 18070 18114 +44
=========================================
+ Hits 13400 13451 +51
+ Misses 4670 4663 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version forced the calculation of all datasets. It now separates all the logic out to create the output NetCDF files during the dask computation steps. This PR also includes support for RGB datasets by splitting the data per-band in to separate files.
git diff origin/master -- "*py" | flake8 --diff