Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start_time and end_time being lists in native_msg reader #428

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

ColinDuff
Copy link
Contributor

Start Time and End Time should be returned as an object not as a list. This causes some issues when using SIFT

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.356% when pulling 5e7f150 on ColinDuff:develop into 855a4ed on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files         128      128           
  Lines       16926    16926           
=======================================
  Hits        12247    12247           
  Misses       4679     4679
Impacted Files Coverage Δ
satpy/readers/native_msg.py 14.95% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855a4ed...5e7f150. Read the comment docs.

@djhoese djhoese requested review from sjoro and adybbroe September 26, 2018 15:49
@djhoese djhoese self-assigned this Sep 26, 2018
@djhoese djhoese added this to the v0.10 milestone Sep 26, 2018
@djhoese
Copy link
Member

djhoese commented Sep 26, 2018

Looks good to me. Maybe @sjoro or @adybbroe can comment on if there was a specific reason this was done originally.

Note to self: I need to cherry pick this to the 0.9 maintenance branch and make a 0.9 release.

@djhoese djhoese merged commit b8671a9 into pytroll:master Sep 26, 2018
@djhoese djhoese changed the title Start and End Time are now returned as datetime objects not Lists Fix start_time and end_time being lists in native_msg reader Sep 26, 2018
@sjoro
Copy link
Collaborator

sjoro commented Sep 27, 2018

i can't remember any particular reason, but i think somewhere along the line of the development for the reader this might have been necessary? dates back to mpop perhaps? also, the reader has worked so there hasn't been a reason to look at this.

Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants