Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap solar and satellite angles in xarray in AVHRR AAPP reader #401

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Aug 22, 2018

In the initial xarray/dask conversion of AAPP AVHRR reader the solar and satellite angles were missed and were not properly converted to xarrays. This PR adds the wrapping.

  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.273% when pulling 9657eed on bugfix-avhrr-aapp-solar-angles into 78314dc on master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit c799d3a into master Aug 22, 2018
@mraspaud mraspaud deleted the bugfix-avhrr-aapp-solar-angles branch August 22, 2018 06:46
@djhoese
Copy link
Member

djhoese commented Aug 22, 2018

Please change the title to be more clear about what reader this is in.

@pnuu pnuu changed the title Wrap solar and satellite angles in xarray Wrap solar and satellite angles in xarray in AVHRR AAPP reader Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants