Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loose print statement and fix future warning #352

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Jun 29, 2018

Signed-off-by: Adam.Dybbroe [email protected]

Fixing issue 345. A loose print statement is removed. And a future warning from xarray is dealt with in the ears-nwc reader

Signed-off-by: Adam.Dybbroe <[email protected]>
@adybbroe
Copy link
Contributor Author

I have removed the print statement that affected all readers. But not yet looked at the warning from xarrat

@mraspaud mraspaud changed the title Remove loose print statement and fix future warning [WIP] Remove loose print statement and fix future warning Jun 29, 2018
@codecov
Copy link

codecov bot commented Jul 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@bc87fed). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #352   +/-   ##
=========================================
  Coverage          ?   70.27%           
=========================================
  Files             ?      123           
  Lines             ?    17436           
  Branches          ?        0           
=========================================
  Hits              ?    12253           
  Misses            ?     5183           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/readers/__init__.py 95.62% <ø> (ø)
satpy/readers/nc_nwcsaf.py 17.02% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc87fed...d3b30a8. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Jul 24, 2018

@adybbroe Do you have an example of the future warning? Maybe someone else could look at the warning and fix it so that we could merge this for 0.9.1.

Edit: Nevermind, I found your example output in your issue.

@djhoese
Copy link
Member

djhoese commented Aug 2, 2018

FYI I found at least one small future warning in the viirs l1b reader where I was doing if 'dim_0' in data: and now it needs to be if 'dim_0' in data.dims: because in the future it will search the values of the data array which is not what we want. Maybe your future warning is something similar, but I haven't actually looked. I will make a pull request for my warning's fix in the next couple days hopefully.

@djhoese djhoese changed the title [WIP] Remove loose print statement and fix future warning Remove loose print statement and fix future warning Aug 15, 2018
@djhoese
Copy link
Member

djhoese commented Aug 15, 2018

@adybbroe If you have a chance to test this that would be great. The xarray related warnings should be fixed now. If you don't get to it before the tests pass I'll just merge it anyway and if you still have the warning we'll open the issue up again.

@djhoese djhoese merged commit 5d8b013 into master Aug 15, 2018
@djhoese djhoese deleted the fix-future-warning-earsnwc-reader branch August 15, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants