Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote reading for hrit seviri #3064

Merged
merged 9 commits into from
Feb 28, 2025
Merged

Conversation

mraspaud
Copy link
Member

This PR adds remote reading to hrit seviri.
Also some cleanup to the native tests.

  • Closes #xxxx
  • Tests added

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Feb 13, 2025
@mraspaud mraspaud self-assigned this Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 92.43697% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (14c9f38) to head (17cf0ce).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/hrit_base.py 57.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
+ Coverage   96.11%   96.14%   +0.03%     
==========================================
  Files         383      383              
  Lines       55685    55785     +100     
==========================================
+ Hits        53523    53636     +113     
+ Misses       2162     2149      -13     
Flag Coverage Δ
behaviourtests 3.88% <0.00%> (-0.01%) ⬇️
unittests 96.24% <92.43%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13314550823

Details

  • 110 of 119 (92.44%) changed or added relevant lines in 7 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 96.252%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/readers/hrit_base.py 12 21 57.14%
Files with Coverage Reduction New Missed Lines %
satpy/readers/utils.py 1 94.5%
satpy/readers/hrit_base.py 7 86.6%
Totals Coverage Status
Change from base Build 13294715027: 0.03%
Covered Lines: 53883
Relevant Lines: 55981

💛 - Coveralls

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot! Nice and clean tests 👍 Just two little questions

@mraspaud mraspaud merged commit e51b97f into pytroll:main Feb 28, 2025
15 of 18 checks passed
@mraspaud mraspaud deleted the feature-hrit-remote branch February 28, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants