Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native_msg calibration bug #285

Merged
merged 2 commits into from
May 8, 2018
Merged

Fix native_msg calibration bug #285

merged 2 commits into from
May 8, 2018

Conversation

sjoro
Copy link
Collaborator

@sjoro sjoro commented May 7, 2018

Fix a bug in get_dataset-method in native_msg.py. Calibrated dataset values were accidentally set back to counts.

  • [ x] Passes git diff origin/develop **/*py | flake8 --diff

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage increased (+0.03%) to 65.124% when pulling b455e2c on sjoro:develop into 7490ccf on pytroll:develop.

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #285 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #285      +/-   ##
===========================================
+ Coverage    65.09%   65.12%   +0.03%     
===========================================
  Files          115      115              
  Lines        14088    14087       -1     
===========================================
+ Hits          9170     9174       +4     
+ Misses        4918     4913       -5
Impacted Files Coverage Δ
satpy/readers/native_msg.py 18.55% <ø> (+0.09%) ⬆️
satpy/scene.py 82.75% <ø> (ø) ⬆️
satpy/readers/__init__.py 94.53% <0%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7490ccf...b455e2c. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the changes in scene.py, please remove them.

@sjoro
Copy link
Collaborator Author

sjoro commented May 8, 2018

Changes in scene.py removed.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mraspaud mraspaud merged commit 5a571b5 into pytroll:develop May 8, 2018
@sjoro sjoro deleted the develop branch November 28, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants