-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rasterio to save geotiffs when available #252
Conversation
satpy/writers/geotiff.py
Outdated
fill_value = np.nan | ||
|
||
try: | ||
import rasterio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'rasterio' imported but unused
Codecov Report
@@ Coverage Diff @@
## develop #252 +/- ##
===========================================
- Coverage 63.89% 61.31% -2.59%
===========================================
Files 112 111 -1
Lines 13858 13704 -154
===========================================
- Hits 8855 8402 -453
- Misses 5003 5302 +299
Continue to review full report at Codecov.
|
6b65fb8
to
4e7a699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This refactors the geotiff writer in a couple new ways:
floating_point
withdtype
which expects a numpy dtype and will figure everything else out after that.XRImage.save
method for better performance.git diff origin/develop **/*py | flake8 --diff