Add CSPP Geo (geocat) AHI reading support #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a reader supports multiple sensors and there are composite configs for each sensor that conflict then there is no telling which one will get loaded first. This allows file handlers to tell the reader what sensor these files belong to.
djhoese
added
enhancement
Codecov Report
@@ Coverage Diff @@
## develop #239 +/- ##
===========================================
+ Coverage 41.06% 60.67% +19.6%
===========================================
Files 212 111 -101
Lines 26842 13673 -13169
===========================================
- Hits 11023 8296 -2727
+ Misses 15819 5377 -10442
Continue to review full report at Codecov.
|
mraspaud
approved these changes
Mar 27, 2018
| @@ -96,7 +96,7 @@ def get_test_content(self, filename, filename_info, filetype_info): | |||
| if key + '/attr/' + a in file_content: | |||
| attrs[a] = file_content[key + '/attr/' + a] | |||
| if val.ndim > 1: | |||
| file_content[key] = DataArray(val, dims=('y', 'x'), attrs=attrs) | |||
| file_content[key] = DataArray(val, dims=('lines', 'elements'), attrs=attrs) | |||
There was a problem hiding this comment.
The test is meant to represent what is in the file. The NetCDF4 utility wrapper does not rename any dimensions so in the geocat files the dimensions are actually lines and elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds AHI dataset identifiers to the geocat reader which will allow full support for CSPP Geo AHI products. Without this added to the reader config the datasets would not have an associated wavelength.
This PR also includes a large-ish change to the base readers and file handlers with a
sensor_namesproperty. Previously this was just an instance attribute. The default behavior is the same as before. The difference happens for any file handler that redefinessensor_nameswhich will be used to determine what sensor's files have been loaded. This was needed for the geocat reader which supports multiple sensors including ABI and AHI. Some of the composite entries for these sensors conflict and in the previous implementation it was loading both ABI and AHI configs and which one took priority was unspecified.git diff origin/develop **/*py | flake8 --diff