Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings with xarray, dask, and numpy #466

Closed
djhoese opened this issue Oct 16, 2018 · 0 comments
Closed

Fix deprecation warnings with xarray, dask, and numpy #466

djhoese opened this issue Oct 16, 2018 · 0 comments
Assignees
@djhoese
Labels
good first issue hacktoberfest help wanted

Comments

@djhoese
Copy link
Member

djhoese commented Oct 16, 2018

When running the unit tests python setup.py test with fairly recent versions of most of satpy's dependencies there are a lot of deprecation warnings. We should probably fix these as soon as possible. Some are my own fault:

/Users/davidh/repos/git/trollimage/trollimage/xrimage.py:400: DeprecationWarning: '_finalize' is deprecated, use 'finalize' instead.
  DeprecationWarning)

But others exist and show up a lot:

/Users/davidh/repos/git/satpy/satpy/composites/viirs.py:158: PendingDeprecationWarning: xarray.ufuncs will be deprecated when xarray no longer supports versions of numpy older than v1.13. Instead, use numpy ufuncs directly.
  suna = xu.rad2deg(suna)
@djhoese djhoese self-assigned this Oct 16, 2018
bertilhatt added a commit to bertilhatt/satpy that referenced this issue Oct 16, 2018
@bertilhatt
Switched xarray.unfuncs to numpy
f614519 
_Doing this as part of my Hacktoberfest contribution_

## Why ## 

Trying to address Issue pytroll#466

## How ## 

The error message clearly recommends a path to stability: switch the same functions to the `numpy` equivalents.

## Comments ## 

The only other reference to `xarray` are `xr.DataArray`. I did not convert them to `numpy` equivalent because I didn’t mention that those would be deprecated (and that would probably cascade a _lot_ more unwanted effects.
@bertilhatt bertilhatt mentioned this issue Oct 16, 2018
Merged
5 tasks
@djhoese djhoese closed this as completed May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djhoese djhoese

Labels
good first issue hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djhoese