Skip to content

Commit

Permalink
Add mock to viirs_edr_active_fires tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rdaruwala committed May 3, 2019
1 parent e32799a commit 3457048
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
14 changes: 6 additions & 8 deletions satpy/readers/viirs_edr_active_fires.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,6 @@ def __init__(self, filename, filename_info, filetype_info):
filename_info: Filename information
filetype_info: Filetype information
"""
super(VIIRSActiveFiresTextFileHandler, self).__init__(filename, filename_info, filetype_info)

if not os.path.isfile(filename):
return

platform_key = {"NPP": "Suomi-NPP", "J01": "NOAA-20", "J02": "NOAA-21"}

self.platform_name = platform_key.get(self.filename_info['satellite_name'].upper(), "unknown")

if filetype_info.get('file_type') == 'fires_text_img':
self.file_content = dd.read_csv(filename, skiprows=15, header=None,
Expand All @@ -109,6 +101,12 @@ def __init__(self, filename, filename_info, filetype_info):
"T13", "Along-scan", "Along-track", "confidence_pct",
"power"])

super(VIIRSActiveFiresTextFileHandler, self).__init__(filename, filename_info, filetype_info)

platform_key = {"NPP": "Suomi-NPP", "J01": "NOAA-20", "J02": "NOAA-21"}

self.platform_name = platform_key.get(self.filename_info['satellite_name'].upper(), "unknown")

def get_dataset(self, dsid, dsinfo):
ds = self[dsid.name].to_dask_array(lengths=True)
data_array = xr.DataArray(ds, dims=("y",), attrs={"platform_name": self.platform_name, "sensor": "VIIRS"})
Expand Down
12 changes: 8 additions & 4 deletions satpy/tests/reader_tests/test_viirs_edr_active_fires.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
import pandas as pd
from satpy.tests.reader_tests.test_netcdf_utils import FakeNetCDF4FileHandler
from satpy.readers.file_handlers import BaseFileHandler
from unittest.mock import patch

if sys.version_info < (2, 7):
import unittest2 as unittest
else:
Expand Down Expand Up @@ -274,6 +276,7 @@ def test_load_dataset(self):
self.assertEqual(v.attrs['sensor'], 'VIIRS')


@patch('satpy.readers.viirs_edr_active_fires.dd.read_csv')
class TestModVIIRSActiveFiresText(unittest.TestCase):
"""Test VIIRS Fires Reader"""
yaml_file = 'viirs_edr_active_fires.yaml'
Expand All @@ -291,7 +294,7 @@ def tearDown(self):
"""Stop wrapping the text file handler"""
self.p.stop()

def test_init(self):
def test_init(self, mock_obj):
"""Test basic init with no extra parameters"""
from satpy.readers import load_reader
r = load_reader(self.reader_configs)
Expand All @@ -302,7 +305,7 @@ def test_init(self):
r.create_filehandlers(loadables)
self.assertTrue(r.file_handlers)

def test_load_dataset(self):
def test_load_dataset(self, csv_mock):
"""Test loading all datasets"""
from satpy.readers import load_reader
r = load_reader(self.reader_configs)
Expand All @@ -328,6 +331,7 @@ def test_load_dataset(self):
self.assertEqual(v.attrs['sensor'], 'VIIRS')


@patch('satpy.readers.viirs_edr_active_fires.dd.read_csv')
class TestImgVIIRSActiveFiresText(unittest.TestCase):
"""Test VIIRS Fires Reader"""
yaml_file = 'viirs_edr_active_fires.yaml'
Expand All @@ -345,7 +349,7 @@ def tearDown(self):
"""Stop wrapping the text file handler"""
self.p.stop()

def test_init(self):
def test_init(self, mock_obj):
"""Test basic init with no extra parameters"""
from satpy.readers import load_reader
r = load_reader(self.reader_configs)
Expand All @@ -356,7 +360,7 @@ def test_init(self):
r.create_filehandlers(loadables)
self.assertTrue(r.file_handlers)

def test_load_dataset(self):
def test_load_dataset(self, mock_obj):
"""Test loading all datasets"""
from satpy.readers import load_reader
r = load_reader(self.reader_configs)
Expand Down

0 comments on commit 3457048

Please sign in to comment.