Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSR script for MERSI-3 onboard FY-3F #226

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Jun 25, 2024

As it says on the tin, this adds a conversion script to generate the RSR file for MERSI-3 onboard FY-3F.

@adybbroe
Copy link
Collaborator

Thanks @simonrp84
I was going to try see if I could run it. But I fail downloading the origonal RSR data from the site you pointed to. I get "Secure Connection Failed". Are you able to get the data from there atm?

@adybbroe
Copy link
Collaborator

@simonrp84 In the mean time could you merge main into this, so we can get the CI failures fixed?

@adybbroe adybbroe self-requested a review June 28, 2024 12:32
@adybbroe adybbroe self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (239c410) to head (102a19f).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          23       23           
  Lines        2535     2535           
=======================================
  Hits         2277     2277           
  Misses        258      258           
Flag Coverage Δ
unittests 89.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukaribbba
Copy link
Contributor

Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe merged commit 3d044ec into pytroll:main Jul 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants