Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove temporary skips in favor of increased tolerances #7355

Merged
merged 6 commits into from
May 3, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 27, 2023

Proper fix for #7347 and #7348.

cc @vfdev-5 @seemethere

@pmeier pmeier marked this pull request as ready for review February 27, 2023 20:58
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping, but the test framework is really, really scaring me

@pytorch-bot
Copy link

pytorch-bot bot commented May 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7355

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 29 New Failures, 2 Unrelated Failures

As of commit 756924c:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base 6e7cecd:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier merged commit 8811c91 into pytorch:main May 3, 2023
@pmeier pmeier deleted the flaky-tol branch May 3, 2023 10:54
@github-actions
Copy link

github-actions bot commented May 3, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 15, 2023
Reviewed By: vmoens

Differential Revision: D45522827

fbshipit-source-id: 5ce80e3b9696b4a07e493981d6eb90e203587897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants