Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropout issue in swin transformers #7224

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Fix dropout issue in swin transformers #7224

merged 5 commits into from
Feb 16, 2023

Conversation

oke-aditya
Copy link
Contributor

Closes #7103

NicolasHug
NicolasHug reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @oke-aditya !
Some minor suggestions below, LMK what you think.

torchvision/models/video/swin_transformer.py Outdated
@@ -124,6 +124,7 @@ def shifted_window_attention_3d(
dropout: float = 0.0,
qkv_bias: Optional[Tensor] = None,
proj_bias: Optional[Tensor] = None,
training: bool = False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set the default to True since it's the default of torch.nn.functional.dropout, and also the default of shifted_window_attention ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well caught this was mistake it should have been True

torchvision/models/swin_transformer.py Show resolved Hide resolved
NicolasHug
NicolasHug approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @oke-aditya , LGTM!

@NicolasHug NicolasHug merged commit 8f198e5 into pytorch:main Feb 16, 2023
facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2023
@NicolasHug @facebook-github-bot
[fbsync] Fix dropout issue in swin transformers (#7224)
e1a8141 
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D44416635

fbshipit-source-id: 8f90f59beb98e36ae98a33a8e1b2abd2d07a430b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
bug cla signed module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropout in SwinTransformer unable to set training=False
3 participants
@oke-aditya @NicolasHug @facebook-github-bot