migrate prototype CI to Nova #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c931ff2.
osalpekar
reviewed
Dec 15, 2022
seemethere
reviewed
Dec 16, 2022
| timeout: 45 | ||
| script: | | ||
| # Mark Build Directory Safe | ||
| git config --global --add safe.directory /__w/vision/vision |
There was a problem hiding this comment.
@osalpekar we should probably just do this in the base linux_job.yml if everyone is having to recreate this
There was a problem hiding this comment.
Do we need it though? I've removed it in 119dc41 and the build is green: https://github.com/pytorch/vision/actions/runs/3731505086/jobs/6329814912. Under what circumstance do we need to? IIRC, this is only related to git submodules which we don't have. I guess it is not harmful, we can just do it by default.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
Summary: * improve prototype GPU CI config * consolidate CPU and GPU prototype workflows * [REVERTME] deactivate other CI * syntax * fix name * fix echo mutex * style * fix runner * add jobname * run all prototype tests * fix mutex echo * cleanup * Revert "[REVERTME] deactivate other CI" This reverts commit c931ff2. * remove old workflows * use free GHA runner for CPU tests * Revert "use free GHA runner for CPU tests" This reverts commit a209b31. * [REVERTME] turn warnings into errors * try fix test warnings * fix module import in tests * revert * int -> float * [REVERTME] why do we have to mark as safe? Reviewed By: NicolasHug Differential Revision: D42414485 fbshipit-source-id: 5cc5ae0e5b2b60c027f030f7b083ef5cc10d62bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Consolidate the prototype CPU and GPU tests using the Nova workflow
Group the output of the individual steps for convenience
Minor cleanup of the script without changing functionality
cc @seemethere @bjuncek