add image or video tolerances for CUDA vs CPU tests #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 14, 2022
Reviewed By: NicolasHug Differential Revision: D41265179 fbshipit-source-id: 718bbcb4d333ecff2533f4ec3b9ecd94c03bc0c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6921. Currently we have a bunch of tests that differ when comparing CPU vs. CUDA. Fortunately, the difference is minimal, i.e.
atol=1for uint8 andatol=1 / 255for float32 is sufficient.These errors have not been surfaced before, because we don't have prototype CUDA tests in CI. Together with #6923, there should be no more errors in the test suite regarding CUDA.
cc @vfdev-5 @datumbox @bjuncek