Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prototype] Clean up features area #6834

Merged
merged 3 commits into from
Oct 25, 2022
Merged

[prototype] Clean up features area #6834

merged 3 commits into from
Oct 25, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 25, 2022 •
edited by pytorch-bot bot
Loading

This PR:

  • Removes the unnecessary LegacyImageType* and LegacyVideoType*.
  • Removes the to_format method from BoundingBox
  • Replaces mypy casts with ignore statements to align with other areas

cc @vfdev-5 @bjuncek @pmeier

@datumbox datumbox requested review from vfdev-5 and pmeier October 25, 2022 10:57
pmeier
pmeier approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. Thanks Vasilis!

torchvision/prototype/features/_bounding_box.py
@@ -61,18 +61,6 @@ def wrap_like(
def __repr__(self, *, tensor_contents: Any = None) -> str: # type: ignore[override]
return self._make_repr(format=self.format, spatial_size=self.spatial_size)

def to_format(self, format: Union[str, BoundingBoxFormat]) -> BoundingBox:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@datumbox datumbox merged commit b45969a into pytorch:main Oct 25, 2022
@datumbox datumbox deleted the prototype/cleanup_features branch October 25, 2022 11:55
facebook-github-bot pushed a commit that referenced this pull request Oct 27, 2022
@datumbox @facebook-github-bot
[fbsync] [prototype] Clean up features area (#6834)
64cbc3a 
Summary:
* Clean ups on `features` area

* remove unncessary imports

Reviewed By: YosuaMichael

Differential Revision: D40722900

fbshipit-source-id: fdf73e2b5b2b8d43224c84a841322b2acbda341b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed code quality module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @pmeier @facebook-github-bot