Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ToDtype to avoid unnecessary to() calls and fixing types on Transform #6773

Merged
merged 6 commits into from
Oct 14, 2022
Merged

Update ToDtype to avoid unnecessary to() calls and fixing types on Transform #6773

merged 6 commits into from
Oct 14, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 14, 2022 •
edited
Loading

As discussed offline this PR:

  • Avoids the unnecessary .to(None) call
  • Fixes the nit on the _transformed_types of Transform to avoid the superfluous features.is_simple_tensor, features._Feature idiom.

@datumbox datumbox requested a review from pmeier October 14, 2022 13:25
pmeier
pmeier approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vasilis!

@datumbox datumbox requested a review from pmeier October 14, 2022 13:36
pmeier
pmeier approved these changes Oct 14, 2022 •
edited
Loading
View reviewed changes
@datumbox
Copy link
Contributor Author

datumbox commented Oct 14, 2022 •
edited
Loading

Fun behaviour of defaultdict:

d = defaultdict(lambda: 10)
d.get(1) # None
d[1] # 10
d.get(1) # 10

@datumbox datumbox added code quality and removed bug labels Oct 14, 2022
@datumbox datumbox changed the title Fix ToDtype to avoid errors when a type is not defined. Update ToDtype to avoid unnecessary to() calls and fixing types on Transform Oct 14, 2022
@datumbox datumbox requested a review from pmeier October 14, 2022 14:26
pmeier
pmeier approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if CI is green. Not making this mistake again 😛

@datumbox
Copy link
Contributor Author

The failing test is unrelated (the flaky gaussian), we are good to go.

@datumbox datumbox merged commit e1aacdd into pytorch:main Oct 14, 2022
@datumbox datumbox deleted the bugfix/todtype branch October 14, 2022 14:52
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
@facebook-github-bot
[fbsync] Update ToDtype to avoid unnecessary to() calls and fixin…
01cd8a0 
…g types on `Transform` (#6773)

Summary:
* Fix `ToDtype` to avoid errors when a type is not defined.

* Nit `(features.is_simple_tensor, features._Feature)` to `(Tensor,)`

* Fixing linter

* Adding comment.

* Switch back to indexing. Python's default dict seems to have a nasty behaviour.

Reviewed By: NicolasHug

Differential Revision: D40427458

fbshipit-source-id: 8b104b0f29e717f216a95bae3aaa5a362b880d6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @pmeier @facebook-github-bot