-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read video from memory newapi #6771
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d334eee
add tensor as optional param
jdsgomes be394ae
add init from memory
jdsgomes 4fa6bd4
fix bug
jdsgomes 11846c1
fix bug
jdsgomes 74b44b5
first working version
jdsgomes 2ddf173
apply formatting and add tests
jdsgomes 94a12b5
simplify tests
jdsgomes 901c530
fix tests
jdsgomes 1b6fee5
fix wrong variable name
jdsgomes f985be0
Merge branch 'main' into read_video_from_mem_newapi
jdsgomes 288afa4
add path as optional parameter
jdsgomes 9bbdd14
add src as optional
jdsgomes 382838d
address pr comments
jdsgomes 5e6cb0d
Fix warning messages
jdsgomes 8eb2692
address pr comments
jdsgomes f4cadbb
Merge branch 'main' into read_video_from_mem_newapi
jdsgomes 6c92e94
make tests stricter
jdsgomes 76ec9d2
Revert "make tests stricter"
jdsgomes c5723f0
Merge branch 'main' into read_video_from_mem_newapi
jdsgomes ca09530
Merge branch 'main' into read_video_from_mem_newapi
jdsgomes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added in the wrong section so reverted the commit. My comment regarding why we cannot make the tests strict from read_from_memory still holds