Make sure we are building against test channel for release #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
requested changes
Jun 14, 2022
malfet
reviewed
Jun 14, 2022
.github/workflows/test-m1.yml
Outdated
Comment on lines
10
to
13
| tags: | ||
| # NOTE: Binary build pipelines should only get triggered on release candidate builds | ||
| # Release candidate tags look like: v1.11.0-rc1 | ||
| - v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+ |
There was a problem hiding this comment.
Why not just add - release/* branches to the list? I.e. as tags must point to commits on release/ branch, tagged tests would be no different then regular CI for pushes to the branch?
There was a problem hiding this comment.
No, it's not (tags are still there)
There was a problem hiding this comment.
Sorry I misunderstood your first comment, added the release branch but thought we still need tests on rc
malfet
approved these changes
Jun 14, 2022
.github/workflows/test-m1.yml
Outdated
Comment on lines
10
to
13
| tags: | ||
| # NOTE: Binary build pipelines should only get triggered on release candidate builds | ||
| # Release candidate tags look like: v1.11.0-rc1 | ||
| - v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+ |
There was a problem hiding this comment.
No, it's not (tags are still there)
|
Hey @atalman! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
atalman
added a commit
to YosuaMichael/vision
that referenced
this pull request
Jun 15, 2022
…6168) * Make sure we are building against test chanell for release * Cleanup * Cleanup * Refactoring logic * Remove tagged tests
facebook-github-bot
pushed a commit
to pytorch/audio
that referenced
this pull request
Jun 15, 2022
Summary: Making sure we are picking correct release branch Ref: pytorch/vision#6168 Pull Request resolved: #2489 Reviewed By: mthrok Differential Revision: D37160145 Pulled By: atalman fbshipit-source-id: 3e4a2208cbe47f85147573159f9adb8d6a824956
atalman
added a commit
to atalman/audio
that referenced
this pull request
Jun 15, 2022
Summary: Making sure we are picking correct release branch Ref: pytorch/vision#6168 Pull Request resolved: pytorch#2489 Reviewed By: mthrok Differential Revision: D37160145 Pulled By: atalman fbshipit-source-id: 3e4a2208cbe47f85147573159f9adb8d6a824956
atalman
added a commit
to atalman/audio
that referenced
this pull request
Jun 15, 2022
Summary: Making sure we are picking correct release branch Ref: pytorch/vision#6168 Pull Request resolved: pytorch#2489 Reviewed By: mthrok Differential Revision: D37160145 Pulled By: atalman fbshipit-source-id: 3e4a2208cbe47f85147573159f9adb8d6a824956
atalman
added a commit
to pytorch/audio
that referenced
this pull request
Jun 15, 2022
* Making sure we are picking correct release branch (#2489) Summary: Making sure we are picking correct release branch Ref: pytorch/vision#6168 Pull Request resolved: #2489 Reviewed By: mthrok Differential Revision: D37160145 Pulled By: atalman fbshipit-source-id: 3e4a2208cbe47f85147573159f9adb8d6a824956 * Fix push on release reference name (#2492) Summary: Fix push on release reference name We want to compare it against refs/heads/release rather then release Tests: atalman/vision@af17cd9 Sets correctly release chanell (wheels): https://github.com/atalman/vision/runs/6901327010?check_suite_focus=true Pull Request resolved: #2492 Reviewed By: hwangjeff Differential Revision: D37174090 Pulled By: atalman fbshipit-source-id: e114972935572a701eb7daff429a0df0ed5a75e4 * Fix typo in release build step (#2495) Summary: Fix typo in release build step Pull Request resolved: #2495 Reviewed By: hwangjeff Differential Revision: D37176695 Pulled By: atalman fbshipit-source-id: 37b4e30c1084e506f3a45cf7427784c955868909 * Making sure channel flag is set correctly
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 16, 2022
…ytorch#6168) Summary: * Make sure we are building against test chanell for release * Cleanup * Cleanup * Refactoring logic * Remove tagged tests Differential Revision: D37212663 fbshipit-source-id: 22c4f1d3892fc9b47b17335e5130b84b14911190
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
…6168) Summary: * Make sure we are building against test chanell for release * Cleanup * Cleanup * Refactoring logic * Remove tagged tests Reviewed By: datumbox Differential Revision: D37212663 fbshipit-source-id: 002dc90a219934439bf3c06c252b310aef6f22e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we are building against test channel when opening PRs against release
Testing in this PR: #6167