Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CIOU loss function #5776
Added CIOU loss function #5776
Changes from all commits
d868ec1
abb09eb
9c2ee2e
f3f1d92
2d0f627
a158ca3
5760487
56147d2
38e7a19
9a1cf90
755fa07
1a6b59a
99a3951
d89dbec
c9b0cab
8c2feee
b1d33fa
c531b1d
19b23d1
916418f
96c6dda
844e0da
38f9ede
2422913
ada4471
b8a7d96
c8a18ce
9b4803a
5cf1591
d25a5a0
14add84
03ecb91
1c4ae7f
2cbc6a2
9c88d92
e36fb15
1e57b6b
7e244fb
47c7e09
f5a352c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
We got methods in
ops.boxes
for estimating intersection and unions. I don't think we can just use them here as-is, but it's worth considering refactoring the entire loss area to avoid re-estimating quantities and instead try use some of the methods from boxes.Moreover it's worth noting that cIoU and dIoU share a large number of common code that could be shared.