Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded value from the ASPP layer (#2780) #2793

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Remove hard coded value from the ASPP layer (#2780) #2793

merged 2 commits into from
Oct 12, 2020

Conversation

AdeelH
Copy link
Contributor

@AdeelH AdeelH commented Oct 12, 2020

Fixes #2780

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @AdeelH !
CI failure is unrelated and can be ignored.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #2793 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2793      +/-   ##
==========================================
+ Coverage   73.12%   73.25%   +0.13%     
==========================================
  Files          96       96              
  Lines        8431     8431              
  Branches     1317     1317              
==========================================
+ Hits         6165     6176      +11     
+ Misses       1865     1855      -10     
+ Partials      401      400       -1     
Impacted Files Coverage Δ
torchvision/models/segmentation/deeplabv3.py 100.00% <ø> (ø)
torchvision/models/detection/rpn.py 93.16% <0.00%> (+0.42%) ⬆️
torchvision/ops/deform_conv.py 70.96% <0.00%> (+3.22%) ⬆️
torchvision/extension.py 68.18% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c4fdf...c4face2. Read the comment docs.

@vfdev-5 vfdev-5 merged commit 610c9d2 into pytorch:master Oct 12, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ASPP layer has a hard-coded value that only works if the atrous_rates param is of length 3
2 participants