Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write_jpeg and write_png in favor of encode + write_file #2766

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Oct 6, 2020

Follow-up from #2765

We don't need to have those functions be in C++ as they are just a combination of encode + write_file

@fmassa fmassa requested a review from andfoy October 6, 2020 19:00
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2766 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
+ Coverage   72.42%   72.76%   +0.33%     
==========================================
  Files          96       96              
  Lines        8313     8313              
  Branches     1293     1292       -1     
==========================================
+ Hits         6021     6049      +28     
+ Misses       1903     1870      -33     
- Partials      389      394       +5     
Impacted Files Coverage Δ
torchvision/io/image.py 89.13% <100.00%> (+4.34%) ⬆️
torchvision/io/_video_opt.py 39.37% <0.00%> (+16.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e639d3...1fdd677. Read the comment docs.

Copy link
Contributor

@andfoy andfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the write_* functions from the documentation, but overall it looks good

@fmassa
Copy link
Member Author

fmassa commented Oct 7, 2020

The write_png and write_jpeg are still present in the codebase, I've just removed the C++ equivalents. But if we remove them in a follow-up PR we do need to change the documentation, yes

@fmassa fmassa merged commit 4b07c78 into pytorch:master Oct 7, 2020
@fmassa fmassa deleted the remove-write_png_jpg_cpp branch October 7, 2020 17:28
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants