Negative padding for functional_pil #2381 #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2744 +/- ##
==========================================
+ Coverage 73.05% 73.07% +0.01%
==========================================
Files 96 96
Lines 8298 8304 +6
Branches 1291 1292 +1
==========================================
+ Hits 6062 6068 +6
Misses 1838 1838
Partials 398 398
Continue to review full report at Codecov.
|
vfdev-5
approved these changes
Oct 2, 2020
jamt9000
added a commit
to jamt9000/vision
that referenced
this pull request
Oct 3, 2020
Along with pytorch#2744 this will make negative padding uniform between PIL and Tensor pytorch#2381
vfdev-5
added a commit
that referenced
this pull request
Oct 5, 2020
* Negative padding for functional_tensor symmetric Along with #2744 this will make negative padding uniform between PIL and Tensor #2381 * Enable tests for negative symmetric pad with tensor Co-authored-by: vfdev <[email protected]>
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Negative padding for functional_pil pytorch#2381 * Tests for PIL negative padding pytorch#2381 * Move PIL vs tensor test inside test_pad * Adapt test_pad from test_transforms_tensor.py Co-authored-by: vfdev <[email protected]>
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Negative padding for functional_tensor symmetric Along with pytorch#2744 this will make negative padding uniform between PIL and Tensor pytorch#2381 * Enable tests for negative symmetric pad with tensor Co-authored-by: vfdev <[email protected]>
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Negative padding for functional_pil pytorch#2381 * Tests for PIL negative padding pytorch#2381 * Move PIL vs tensor test inside test_pad * Adapt test_pad from test_transforms_tensor.py Co-authored-by: vfdev <[email protected]>
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Negative padding for functional_tensor symmetric Along with pytorch#2744 this will make negative padding uniform between PIL and Tensor pytorch#2381 * Enable tests for negative symmetric pad with tensor Co-authored-by: vfdev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix as discussed in #2381 (tests to follow)