Require CMP0053=New. #2739
Merged
Require CMP0053=New. #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to workaround CMake 3.18.3 bug with a bad regex, which happens to be valid with new parser. Since probably any distro with CMake 3 won't stuck with 3.0, there shall be no real impact with this increase. Fix pytorch#2701
Codecov Report
@@ Coverage Diff @@
## master #2739 +/- ##
=======================================
Coverage 73.05% 73.05%
=======================================
Files 96 96
Lines 8298 8298
Branches 1291 1291
=======================================
Hits 6062 6062
Misses 1838 1838
Partials 398 398 Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
This is to workaround CMake 3.18.3 bug with a bad regex, which happens to be valid with new parser. Since probably any distro with CMake 3 won't stuck with 3.0, there shall be no real impact with this increase. Fix pytorch#2701
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
This is to workaround CMake 3.18.3 bug with a bad regex, which happens to be valid with new parser. Since probably any distro with CMake 3 won't stuck with 3.0, there shall be no real impact with this increase. Fix pytorch#2701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to workaround CMake 3.18.3 bug with a bad regex, which happens to be valid with new parser.
Since probably any distro with CMake 3 won't stuck with 3.0, there shall be no real impact with this increase.
Fix #2701