-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tensor transforms jupyter notebook #2730
Added tensor transforms jupyter notebook #2730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2730 +/- ##
=========================================
Coverage ? 72.87%
=========================================
Files ? 96
Lines ? 8309
Branches ? 1292
=========================================
Hits ? 6055
Misses ? 1858
Partials ? 396
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have some early comments, which are nits
ToDo: Improve inference example
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the improvements, this is looking great!
I've made some more comments, let me know what you think
+ updated docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks!
I can't comment on the specific lines of the notebook because it's too large (due to the images) so GitHub won't show it. There are a few minor things that I think could be improved, but they can be added in a follow-up PR.
There are a few empty cells that could be cleaned up as well.
Also, is there a way of making the notebook a bit smaller? It's currently > 1MB, maybe cleaning up the images (by removing the output of all cells) could help there?
@fmassa thanks for the review, I can address all that in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
* [WIP] Added scriptable transforms python example * Replaced script file with jupyter notebook * Updated readme * Updates according to review + updated docstrings * Updated notebook and docstring according to the review * torch script -> torchscript
* [WIP] Added scriptable transforms python example * Replaced script file with jupyter notebook * Updated readme * Updates according to review + updated docstrings * Updated notebook and docstring according to the review * torch script -> torchscript
Description: