Add encoding and writing PNG ops #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
+ Coverage 72.91% 72.93% +0.01%
==========================================
Files 95 95
Lines 8233 8238 +5
Branches 1279 1279
==========================================
+ Hits 6003 6008 +5
Misses 1838 1838
Partials 392 392
Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Add encode/write_png functions * Do not redefine * Style issues correction * Comply with low-level interface * Minor comment correction * Add python frontend functions * Add encode_png test * Pass compession level to encode_png * Do not compare output buffers * Convert to bytes * Compare pil image instead of buffer * Add error tests * Add test_write_png * Remove png test assets * Register writePNG correctly * Update write_png docstring * Do not preserve PIL image beyond the scope Co-authored-by: Francisco Massa <[email protected]>
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Add encode/write_png functions * Do not redefine * Style issues correction * Comply with low-level interface * Minor comment correction * Add python frontend functions * Add encode_png test * Pass compession level to encode_png * Do not compare output buffers * Convert to bytes * Compare pil image instead of buffer * Add error tests * Add test_write_png * Remove png test assets * Register writePNG correctly * Update write_png docstring * Do not preserve PIL image beyond the scope Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new encoding and writing operators to the torchvision image frontend, as follows:
encode_png: Takes a CHW tensor as input and produces a byte buffer containing the PNG file in tensor form.write_png: Takes a CHW tensor and a filename and writes the image into a PNG file in disk.