Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run download tests on a daily schedule #2675

Merged
merged 10 commits into from
Sep 22, 2020
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 14, 2020

Closes #2617.

Comment on lines 6 to 7
- ".github/workflows/tests-schedule.yml"
- "test/test_datasets_download.py"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a PR changes on of these files, we run these tests off-schedule to see if the tests are going through at all. Since this should not be happening often, I think this OK.

@pmeier pmeier requested review from fmassa and seemethere September 14, 2020 13:09
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #2675 into master will increase coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2675      +/-   ##
==========================================
+ Coverage   70.73%   72.79%   +2.06%     
==========================================
  Files          95       95              
  Lines        8203     8203              
  Branches     1280     1280              
==========================================
+ Hits         5802     5971     +169     
+ Misses       2000     1841     -159     
+ Partials      401      391      -10     
Impacted Files Coverage Δ
torchvision/io/video.py 69.82% <0.00%> (+1.18%) ⬆️
torchvision/ops/deform_conv.py 70.00% <0.00%> (+3.33%) ⬆️
torchvision/models/detection/rpn.py 93.13% <0.00%> (+4.72%) ⬆️
torchvision/models/detection/roi_heads.py 82.34% <0.00%> (+5.10%) ⬆️
torchvision/__init__.py 78.12% <0.00%> (+6.25%) ⬆️
torchvision/datasets/video_utils.py 84.84% <0.00%> (+7.27%) ⬆️
torchvision/ops/poolers.py 97.05% <0.00%> (+12.74%) ⬆️
torchvision/ops/boxes.py 100.00% <0.00%> (+15.55%) ⬆️
torchvision/models/detection/transform.py 95.55% <0.00%> (+17.22%) ⬆️
torchvision/extension.py 70.27% <0.00%> (+21.62%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ba453...56b463f. Read the comment docs.

@pmeier
Copy link
Collaborator Author

pmeier commented Sep 17, 2020

@seemethere GitHub Actions CI is not spinning up at all. I've removed all triggers besides a PR so that should not be an issue. Could you look in the organization settings if local and third-party Actions are enabled?

@fmassa
Copy link
Member

fmassa commented Sep 21, 2020

I think actions might be enabled but only run on branches from within the PyTorch org. In your case, your PR is from your fork, which could explain this. @seemethere do you happen to know if that's indeed the case?

@pmeier
Copy link
Collaborator Author

pmeier commented Sep 21, 2020

@fmassa Should I create a dummy workflow in a separate PR to confirm this?

@fmassa
Copy link
Member

fmassa commented Sep 21, 2020

@pmeier yes, let's start with a dummy workflow to try seeing if it works first

@pmeier
Copy link
Collaborator Author

pmeier commented Sep 22, 2020

@fmassa The dummy workflow ran and (expectedly) failed https://github.com/pytorch/vision/runs/1148542519. I'll revert the temporary changes here and afterwards this should be good to merge

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Next step is figure out a way of avoiding re-opening an issue if the job continues failing.

@fmassa fmassa merged commit be0b6d9 into pytorch:master Sep 22, 2020
@pmeier pmeier mentioned this pull request Sep 24, 2020
2 tasks
@pmeier pmeier deleted the tests-schedule branch October 21, 2020 15:06
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* run download tests on a daily schedule

* add blank line

* add issue template as workflow trigger

* try broaden workflow triggers

* run scheduled test after nightlies are published

* try remove schedule as workflow trigger

* restore workflow triggers

* cleanup

* Revert "remove dummy workflow"

This reverts commit d094e4b.

* cleanup
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
* run download tests on a daily schedule

* add blank line

* add issue template as workflow trigger

* try broaden workflow triggers

* run scheduled test after nightlies are published

* try remove schedule as workflow trigger

* restore workflow triggers

* cleanup

* Revert "remove dummy workflow"

This reverts commit d094e4b.

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test dataset downloadability on a schedule
3 participants