-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run download tests on a daily schedule #2675
Conversation
.github/workflows/tests-schedule.yml
Outdated
- ".github/workflows/tests-schedule.yml" | ||
- "test/test_datasets_download.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a PR changes on of these files, we run these tests off-schedule to see if the tests are going through at all. Since this should not be happening often, I think this OK.
Codecov Report
@@ Coverage Diff @@
## master #2675 +/- ##
==========================================
+ Coverage 70.73% 72.79% +2.06%
==========================================
Files 95 95
Lines 8203 8203
Branches 1280 1280
==========================================
+ Hits 5802 5971 +169
+ Misses 2000 1841 -159
+ Partials 401 391 -10
Continue to review full report at Codecov.
|
@seemethere GitHub Actions CI is not spinning up at all. I've removed all triggers besides a PR so that should not be an issue. Could you look in the organization settings if local and third-party Actions are enabled? |
I think actions might be enabled but only run on branches from within the PyTorch org. In your case, your PR is from your fork, which could explain this. @seemethere do you happen to know if that's indeed the case? |
@fmassa Should I create a dummy workflow in a separate PR to confirm this? |
@pmeier yes, let's start with a dummy workflow to try seeing if it works first |
@fmassa The dummy workflow ran and (expectedly) failed https://github.com/pytorch/vision/runs/1148542519. I'll revert the temporary changes here and afterwards this should be good to merge |
24c1744
to
f122cdd
Compare
This reverts commit d094e4b.
f122cdd
to
94a637e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Next step is figure out a way of avoiding re-opening an issue if the job continues failing.
* run download tests on a daily schedule * add blank line * add issue template as workflow trigger * try broaden workflow triggers * run scheduled test after nightlies are published * try remove schedule as workflow trigger * restore workflow triggers * cleanup * Revert "remove dummy workflow" This reverts commit d094e4b. * cleanup
* run download tests on a daily schedule * add blank line * add issue template as workflow trigger * try broaden workflow triggers * run scheduled test after nightlies are published * try remove schedule as workflow trigger * restore workflow triggers * cleanup * Revert "remove dummy workflow" This reverts commit d094e4b. * cleanup
Closes #2617.