Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning to the documentation of F_pil and F_t functions (2547) #2664

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Added warning to the documentation of F_pil and F_t functions (2547) #2664

merged 2 commits into from
Sep 14, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 10, 2020 •
edited
Loading

Fixes #2547

Description

  • Added warning to the documentation of F_pil and F_t functions

@vfdev-5
Fixes pytorch#2547
6e61d2e 
- Added warning to the documentation of F_pil and F_t functions
@codecov
Copy link

codecov bot commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #2664 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
- Coverage   72.41%   72.23%   -0.19%     
==========================================
  Files          95       95              
  Lines        8245     8399     +154     
  Branches     1308     1366      +58     
==========================================
+ Hits         5971     6067      +96     
- Misses       1858     1920      +62     
+ Partials      416      412       -4
Impacted Files Coverage Δ
torchvision/transforms/functional_pil.py 67.14% <ø> (ø)
torchvision/transforms/functional_tensor.py 69.07% <ø> (+2.22%) ⬆️
torchvision/io/video.py 54.77% <0.00%> (-15.06%) ⬇️
torchvision/datasets/samplers/clip_sampler.py 85.60% <0.00%> (+6.05%) ⬆️
torchvision/io/image.py 79.41% <0.00%> (+7.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4736ea...133624e. Read the comment docs.

@vfdev-5 vfdev-5 requested a review from fmassa September 11, 2020 09:30
fmassa
fmassa reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

There is a copy-paste issue, otherwise the PR is good to merge after this is fixed

torchvision/transforms/functional_tensor.py Outdated Show resolved Hide resolved
fmassa
fmassa approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit 38aab83 into pytorch:master Sep 14, 2020
@vfdev-5 vfdev-5 deleted the vfdev-5/issue-2547-private-f-api branch September 14, 2020 15:18
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@vfdev-5 @bryant1410
Added warning to the documentation of F_pil and F_t functions (2547) (p…
7935fe9 
…ytorch#2664)

* Fixes pytorch#2547

- Added warning to the documentation of F_pil and F_t functions

* Update functional_tensor.py
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@vfdev-5
Added warning to the documentation of F_pil and F_t functions (2547) (p…
2ae8e3b 
…ytorch#2664)

* Fixes pytorch#2547

- Added warning to the documentation of F_pil and F_t functions

* Update functional_tensor.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning to the documentation of F_pil and F_t functions
2 participants
@vfdev-5 @fmassa