-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places365 dataset #2610
Places365 dataset #2610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, thanks a lot @pmeier !
I think this looks good to be merged, I have only a few questions / comments.
This PR is missing an entry in the documentation in https://github.com/pytorch/vision/blob/master/docs/source/datasets.rst , can you add one there (we have just sorted it alphabetically)
For a future PR, I think it might make sense to split the tests for Places365 in its own Tester class (still in the same file is ok), as we have quite a few test functions there.
So basically class Places365Tester(TestCase):
pass ? |
Yes, something like class TesterBase(TestCase):
# base implementation for tester
def generic_classification_dataset_test(...)
...
class Tester(TesterBase): # find better name
# all datasets tests that are implemented as a single function
def test_imagefolder(...):
...
class Places365Tester(TesterBase):
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
* initial draft * [dirty] progress * remove inheritance from ImageFolder * add tests * lint * fix type hints * align getitem with other datasets * remove unused import * add docstring * guard existing image folders from overwrite * add missing entry in docstring * make fixpath more legible * add Places365 to docs
This adds the Places365 dataset. As the name implies it comprises 365 categories of "places". It is structured in 4 different splits:
training-standard
(~1.8e6
images)training-challenge
(~8e6
images)val
(~18e3
images)test
(~330e3
images)With the flag
small
the user can switch between high resolution and small (256 x 256
) images.