Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPU unit tests #2465

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Fix CPU unit tests #2465

merged 1 commit into from
Jul 13, 2020

Conversation

guyang3532
Copy link
Contributor

Currently the CUDA_VERSION is not set rightly.

@guyang3532
Copy link
Contributor Author

@peterjc123

peterjc123
peterjc123 approved these changes Jul 13, 2020
View reviewed changes
.circleci/unittest/linux/scripts/install.sh Outdated Show resolved Hide resolved
peterjc123
peterjc123 suggested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure in unittest_linux_gpu_py3.8 is legit

peterjc123
peterjc123 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it failed because the pytorch nightlies packages are unavailable. I'm going to merge it optimistically.

@peterjc123 peterjc123 merged commit 812395c into pytorch:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjc123 peterjc123 peterjc123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyang3532 @peterjc123