-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Read JPEG images directly #2388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
+ Coverage 70.68% 71.79% +1.10%
==========================================
Files 94 94
Lines 7905 8254 +349
Branches 1245 1371 +126
==========================================
+ Hits 5588 5926 +338
+ Misses 1932 1931 -1
- Partials 385 397 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR!
I think this is good to merge, I only have a couple of comments (tests and .accessor
.
Also, I wonder if we could in a follow-up PR maybe look into some small optimizations / improvements that I pointed out?
const static JOCTET EOI_BUFFER[1] = {JPEG_EOI}; | ||
char jpegLastErrorMsg[JMSG_LENGTH_MAX]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a next PR: it would be great if there was a way of avoiding having those globals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
No description provided.