Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin ninja version for Windows jobs #2319

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Pin ninja version for Windows jobs #2319

merged 3 commits into from
Jun 17, 2020

Conversation

peterjc123
Copy link
Contributor

No description provided.

seemethere
seemethere reviewed Jun 15, 2020
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just pin it for everything?

@peterjc123
Copy link
Contributor Author

@seemethere Nope, the linux one is fine.

@fmassa
Copy link
Member

fmassa commented Jun 16, 2020

FYI there is a breakage introduced in PyTorch which affects torchvision CI.
It should be fixed with pytorch/pytorch#40041

@peterjc123
Copy link
Contributor Author

peterjc123 commented Jun 16, 2020 •
edited
Loading

@fmassa Yeah, I know. That's why I opened #2320. Actually you could merge it so that the wheel jobs for Windows will be fixed.

@ezyang
Copy link
Contributor

ezyang commented Jun 16, 2020

TBH you should still just pin it for everything

@peterjc123
Copy link
Contributor Author

@ezyang @seemethere Done.

@peterjc123 peterjc123 requested a review from seemethere June 17, 2020 03:17
@fmassa fmassa merged commit 148bac2 into pytorch:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang Awaiting requested review from ezyang

@fmassa fmassa Awaiting requested review from fmassa

@seemethere seemethere Awaiting requested review from seemethere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterjc123 @fmassa @ezyang @seemethere