-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove default to ignore safetensors #2042
remove default to ignore safetensors #2042
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2042
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b05689b with merge base e9fd56a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -99,7 +99,7 @@ To download the Llama3.1-405B-Instruct model: | |||
tune download meta-llama/Meta-Llama-3.1-405B-Instruct --ignore-patterns "original/consolidated*" --hf-token <HF_TOKEN> | |||
|
|||
To download the Llama3 weights of the above models, you can instead download from `Meta-Llama-3-8B-Instruct` and | |||
`Meta-Llama-3-70B-Instruct`. | |||
`Meta-Llama-3-70B-Instruct`, and remove the ignore patterns flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, 8b uses meta ckpt, and 70b uses hg ckpt. Ideally, we should update their configs to all use hf, so we can always ignore consolidated. To avoid adding too much info here, i suggested that the user can just remove the ignore patterns flag, downloading all models.
torchtune/_cli/download.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the mention of this in kaggle_download as well.
Not important but just for cleanliness, you could remove any
|
yessir |
Context
What is the purpose of this PR? Is it to
bad default
Testing:
Downloaded models