Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Correct compile_loss return type hint #1940

Merged
merged 1 commit into from
Nov 1, 2024
+1 −1
Merged

nit: Correct compile_loss return type hint #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchtune/training/_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def compile_model(
model.compile(backend=backend)


def compile_loss(loss: nn.Module, verbose: bool = True) -> None:
def compile_loss(loss: nn.Module, verbose: bool = True) -> nn.Module:
"""
Utility to compile and return loss function. If the loss function is chunked cross-entropy,
we only compile the upcast + cross-entropy calculation, not the chunking. For other losses
Expand Down