Remove tensor subclass detection logic from weights_only unpickler #127808
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127808
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit c675f31 with merge base 1b704a1 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mikaylagawarecki
changed the title
mikaylagawarecki
added
module: python frontend
ghstack-source-id: 29dff9bf4e999d3ca4db4d5d74d981bfa1c2beb6 Pull Request resolved: #127808
| for method, func in restore_methods.items(): | ||
| setattr(subclass, method, func) | ||
| a = subclass(torch.randn(2, 3)) | ||
|
|
||
| @skipIfTorchDynamo("name 'SYNTHETIC_LOCAL' is not defined") | ||
| def test_safe_globals_for_weights_only(self): |
There was a problem hiding this comment.
@malfet This tests that functionality with TwoTensor, is that what you were looking for?
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: .github/workflows/generated-linux-binary-manywheel-main.yml / manywheel-py3_8-cuda11_8-test / test Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Add context manager mentioned in #127808 (review) Pull Request resolved: #127939 Approved by: https://github.com/albanD
Add context manager mentioned in pytorch#127808 (review) Pull Request resolved: pytorch#127939 Approved by: https://github.com/albanD
Remove logic to auto-detect and allow subclasses that did not override certain methods from the weights_only unpickler from #124331 for 2.4 release
Subclasses should be loadable using
torch.serialization.add_safe_globalsStack from ghstack (oldest at bottom):
cc @albanD